commit | bddb0234c7430fc322ddc959a75635d4b34bbc2e | [log] [tgz] |
---|---|---|
author | David Ostrovsky <david@ostrovsky.org> | Wed Mar 11 09:57:47 2015 +0100 |
committer | David Pursehouse <david.pursehouse@sonymobile.com> | Mon Sep 14 04:27:44 2015 +0000 |
tree | dd7085257484a2b05d68eb21fed9a624ea980197 | |
parent | 26da0269eaba3800fc273703d9bb8a392a4092dd [diff] |
Detect LDAP misconfiguration and fail earlier Currently supported LDAP backends accept dozens of configuration options. Some options are only supported by one backend, but not others. The current code doesn't check if supplied option is supported or not by the actual backend. Instead of curing the symptoms by spreading obfuscated checks across the code base to detect and ignore the invalid configuration, cure the disease: reject misconfiguration when supplied option is not supported by the actual backend. Example: RFC2307 backend doesn't accept ldap.accountMemberField With this change, trying to supply it results in the error message: "LDAP backend doesn't support: ldap.accountMemberField" The following error message is reported to the user: "Authentication unavailable at this time." Change-Id: Ib82b5313dcaa892e41fd16482918e02a77381303
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && buck build all
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.