commit | bd778f8c011fe77449be62e87b080040cabd25f3 | [log] [tgz] |
---|---|---|
author | Dave Borowitz <dborowitz@google.com> | Fri Mar 31 15:48:55 2017 -0400 |
committer | Dave Borowitz <dborowitz@google.com> | Fri Mar 31 16:08:05 2017 -0400 |
tree | 666b9a0f4658c5d1eed55ce3e664c6920ae02bdd | |
parent | 7261ceb876d7311c2dbcee3106f2c2050003e8fd [diff] |
Expose RevWalk in CommitReceivedEvent CommitValidationListeners are called from the body of BatchUpdateOp#updateRepo implementations prior to flushing the inserter that created them. Thus, an implementation relying on just the commit SHA-1 and the project name will be unable to actually read the commit or, say, its tree. Include a RevWalk in the event, and ensure that the RevCommit is parsed using this RevWalk. This also avoids another class of bugs where the caller constructs their own RevWalk which is different from the one that created the RevCommit. We could have passed the RevWalk that parsed the original copy of the commit, but this would allow plugin implementations to reset it or set additional flags/options. Since this listener is called from ReceiveCommits, we can't let them do that lest they mess up the walk over new changes. Bug: Issue 5914 Change-Id: Iaf8317cb344fab0a2f87a1e11bff2642445ed510
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.