| commit | cb2ba3e7f9aa8899a48e677fedf5dbfe01add522 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Dec 27 14:29:32 2018 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Dec 27 14:29:32 2018 +0100 |
| tree | 840bcd5a5da3b7e327372dca681e8b1bed617808 | |
| parent | b60e7643dc86d952d16d9fb8d3d04122f839a97b [diff] |
CommentJsonMigrator: Improve error handling if comment note is too large Schema 169 migrates comments in NoteDb to JSON. To check whether comments need to be migrated the note blob with the comments needs to be loaded. Loading the note blob failed if the blob was larger than 25 MB and the schema migration failed with LargeObjectException. The 25 MB limit was hard-coded. This change removes this hard-coded limit. Loading the blob could still fail with LargeObjectException if the object is too large to fit into a byte array. To prevent this we check whether the object is too large before attempting to load it. If it's too large we fail with an IOException. This is better than failing with a LargeObjectException since it results in a proper log that says for which change the problem occurred. After logging the IOException it is ignored and the migration is attempted despite of it. It's not unlikely that the migration still fails for note blobs that are larger than 25 MB because the 25 MB limit for note blobs is also checked in other places (e.g. in RevisionNote#parse()), but at least this change improves the error reporting and should reveal if there are other places during the migration that have a hard-coded limit. Change-Id: Idaef9a65b7fcbd9e593ffbd7c097cbffd105a916 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.