Add Documentation:js_licenses.txt for JavaScript
//Documentation:js_licenses.txt is an optional target to build
the closure of licenses that are compiled into the JavaScript
by the GWT compiler. This is a subset of what is inside of
licenses.txt, but this subset may be necessary in some cases.
Explicitly break some edges that would otherwise by found
in the build graph to avoid dragging in license information
that is not necessary in the partial report created by the
js_licenses.txt target.
Change-Id: Ibbebb3365faf8dccbcd02ad7ef82280255fc5245
diff --git a/Documentation/BUCK b/Documentation/BUCK
index 48a6525..dfac617 100644
--- a/Documentation/BUCK
+++ b/Documentation/BUCK
@@ -3,7 +3,8 @@
include_defs('//tools/git.defs')
DOC_DIR = 'Documentation'
-MAIN = ['//gerrit-pgm:pgm', '//gerrit-gwtui:ui_module']
+JSUI = ['//gerrit-gwtui:ui_module']
+MAIN = ['//gerrit-pgm:pgm'] + JSUI
SRCS = glob(['*.txt'], excludes = ['licenses.txt'])
genasciidoc(
@@ -29,11 +30,19 @@
genrule(
name = 'licenses.txt',
- cmd = '$(exe :gen_licenses) >$OUT',
- deps = [':gen_licenses'] + MAIN,
+ cmd = '$(exe :gen_licenses) --asciidoc ' + ' '.join(MAIN) + ' >$OUT',
+ deps = MAIN,
out = 'licenses.txt',
)
+# Required by Google for gerrit-review.
+genrule(
+ name = 'js_licenses.txt',
+ cmd = '$(exe :gen_licenses) --partial ' + ' '.join(JSUI) + ' >$OUT',
+ deps = JSUI,
+ out = 'js_licenses.txt',
+)
+
genrule(
name = 'doc.css',
srcs = ['doc.css.in'],
diff --git a/Documentation/gen_licenses.py b/Documentation/gen_licenses.py
index 19f73fa..8b2d096 100755
--- a/Documentation/gen_licenses.py
+++ b/Documentation/gen_licenses.py
@@ -17,6 +17,7 @@
from __future__ import print_function
+import argparse
from collections import defaultdict, deque
from os import chdir, path
import re
@@ -24,7 +25,12 @@
from subprocess import Popen, PIPE
from sys import stdout, stderr
-MAIN = ['//gerrit-pgm:pgm', '//gerrit-gwtui:ui_module']
+parser = argparse.ArgumentParser()
+parser.add_argument('--asciidoc', action='store_true')
+parser.add_argument('--partial', action='store_true')
+parser.add_argument('targets', nargs='+')
+args = parser.parse_args()
+
KNOWN_PROVIDED_DEPS = [
'//lib/bouncycastle:bcpg',
'//lib/bouncycastle:bcpkix',
@@ -36,13 +42,23 @@
while not path.isfile('.buckconfig'):
chdir('..')
p = Popen(
- ['buck', 'audit', 'classpath', '--dot'] + MAIN,
+ ['buck', 'audit', 'classpath', '--dot'] + args.targets,
stdout = PIPE)
for line in p.stdout:
m = re.search(r'"(//.*?)" -> "(//.*?)";', line)
if not m:
continue
target, dep = m.group(1), m.group(2)
+ if args.partial:
+ if dep == '//lib/codemirror:js_minifier':
+ if target == '//lib/codemirror:js':
+ continue
+ if target.startswith('//lib/codemirror:mode_'):
+ continue
+ if target == '//gerrit-gwtui:ui_module' and \
+ dep == '//gerrit-gwtexpui:CSS':
+ continue
+
# Dependencies included in provided_deps set are contained in audit
# classpath and must be sorted out. That's safe thing to do because
# they are not included in the final artifact.
@@ -60,7 +76,7 @@
graph = parse_graph()
licenses = defaultdict(set)
-queue = deque(MAIN)
+queue = deque(args.targets)
while queue:
target = queue.popleft()
for dep in graph[target]:
@@ -70,7 +86,8 @@
queue.extend(graph[target])
used = sorted(licenses.keys())
-print("""\
+if args.asciidoc:
+ print("""\
Gerrit Code Review - Licenses
=============================
@@ -122,26 +139,33 @@
for n in used:
libs = sorted(licenses[n])
name = n[len('//lib:LICENSE-'):]
- print()
- print('[[%s]]' % name.replace('.', '_'))
- print(name)
- print('~' * len(name))
- print()
+ if args.asciidoc:
+ print()
+ print('[[%s]]' % name.replace('.', '_'))
+ print(name)
+ print('~' * len(name))
+ print()
+ else:
+ print()
+ print(name)
+ print('--')
for d in libs:
if d.startswith('//lib:') or d.startswith('//lib/'):
p = d[len('//lib:'):]
else:
p = d[d.index(':')+1:].lower()
print('* ' + p)
- print()
- print('[[license]]')
- print('[verse]')
- print('--')
+ if args.asciidoc:
+ print()
+ print('[[license]]')
+ print('[verse]')
+ print('--')
with open(n[2:].replace(':', '/')) as fd:
copyfileobj(fd, stdout)
print('--')
-print("""
+if args.asciidoc:
+ print("""
GERRIT
------
Part of link:index.html[Gerrit Code Review]
diff --git a/gerrit-common/BUCK b/gerrit-common/BUCK
index 718c751..efe9595 100644
--- a/gerrit-common/BUCK
+++ b/gerrit-common/BUCK
@@ -31,7 +31,7 @@
'//gerrit-prettify:client',
'//gerrit-reviewdb:client',
'//lib:gwtjsonrpc',
- '//lib:gwtorm',
+ '//lib:gwtorm_client',
'//lib/jgit:Edit',
],
visibility = ['PUBLIC'],
diff --git a/gerrit-gwtui/BUCK b/gerrit-gwtui/BUCK
index ce6e081..0437f5c 100644
--- a/gerrit-gwtui/BUCK
+++ b/gerrit-gwtui/BUCK
@@ -41,7 +41,7 @@
'//gerrit-gwtexpui:CSS',
'//lib:gwtjsonrpc',
'//lib:gwtjsonrpc_src',
- '//lib:gwtorm',
+ '//lib:gwtorm_client',
'//lib/codemirror:codemirror',
'//lib/gwt:user',
'//lib/jgit:Edit',
@@ -49,6 +49,7 @@
visibility = [
'//tools/eclipse:classpath',
'//Documentation:licenses.txt',
+ '//Documentation:js_licenses.txt',
],
)
diff --git a/gerrit-prettify/BUCK b/gerrit-prettify/BUCK
index 2a5367e..cde606b 100644
--- a/gerrit-prettify/BUCK
+++ b/gerrit-prettify/BUCK
@@ -15,7 +15,6 @@
'//gerrit-patch-jgit:client',
'//gerrit-reviewdb:client',
'//gerrit-gwtexpui:SafeHtml',
- '//lib:guava',
'//lib:gwtjsonrpc',
'//lib/gwt:user',
'//lib/jgit:Edit',
diff --git a/gerrit-reviewdb/BUCK b/gerrit-reviewdb/BUCK
index 074e07b..7bed0f3 100644
--- a/gerrit-reviewdb/BUCK
+++ b/gerrit-reviewdb/BUCK
@@ -7,8 +7,8 @@
gwt_xml = SRC + 'ReviewDB.gwt.xml',
deps = [
'//gerrit-extension-api:client',
- '//lib:gwtorm',
- '//lib:gwtorm_src'
+ '//lib:gwtorm_client',
+ '//lib:gwtorm_client_src'
],
visibility = ['PUBLIC'],
)
diff --git a/lib/BUCK b/lib/BUCK
index d2f71e1..6a6871e 100644
--- a/lib/BUCK
+++ b/lib/BUCK
@@ -25,15 +25,21 @@
define_license(name = 'DO_NOT_DISTRIBUTE')
maven_jar(
- name = 'gwtorm',
+ name = 'gwtorm_client',
id = 'com.google.gerrit:gwtorm:1.14-14-gf54f1f1',
bin_sha1 = 'c02267e0245dd06930ea64a2d7c5ddc5ba6d9cfb',
src_sha1 = '3d17ae8a173eb34d89098c748f28cddd5080adbc',
license = 'Apache2.0',
- deps = [':protobuf'],
repository = GERRIT,
)
+java_library(
+ name = 'gwtorm',
+ exported_deps = [':gwtorm_client'],
+ deps = [':protobuf'],
+ visibility = ['PUBLIC'],
+)
+
maven_jar(
name = 'gwtjsonrpc',
id = 'gwtjsonrpc:gwtjsonrpc:1.7-2-g272ca32',
