Google Git
Sign in
gerrit / gerrit / bd2d7ab59696d932d3ba5369dd331d6a471d891c
commitbd2d7ab59696d932d3ba5369dd331d6a471d891c[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Thu Feb 10 07:54:11 2022 +0100
committerEdwin Kempin <ekempin@google.com>Thu Feb 10 10:54:48 2022 +0100
treec172578b58ef22f29bbd5b93ebf6c77ee4dd3f62
parent719f394b05685207930230ec66bc829c094bb86c [diff]
CherryPick: Allow to specify options for the commit validation

When a change is created by pushing a commit for review it is possible
to specify push options. These push options are forwarded to the commit
validation listeners. This enables the commit validation listeners to
skip the validation if a certain push option was set (also see change
If9d82a37c). Push options to skip certain commit validations are for
example supported by the uploadvalidator plugin and the code-owners
plugin.

With this change we allow callers of the Cherry Pick Revision REST
endpoint to set validation options in the CherryPickInput that are
forwarded as push options to the commit validation listeners. This way
commit validation can also be skipped when creating a change / patch set
via the Cherry Pick Revision REST endpoint.

The same is already possible for the Create Change REST endpoint (see
change I936a8b6d6.

This is important when the Cherry Pick Revision REST endpoint is used to
create changes / patch sets with conflicts allowed. If conflicts are
allowed, commit validations that check the validity of files in the
commit will fail if these files contains conflicts (because the Git
conflict markers will be recognised as invalid input). In this case the
change / patch set creation fails due to the validation and so far it
was not possible to skip the validation and make the change / patch set
creation work. By allowing to specify validation options, commit
validations can be skipped now and the change / patch set can be created
with conflicts in the files.

Gerrit core doesn't support any validation options yet, but commit
validation listeners that are implemented in plugins may.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I66dc4cfda33b780125836af44df582355f43133f
Release-Notes: Add support for specifying validation options in Cherry Pick Revision REST endpoint
6 files changed
tree: c172578b58ef22f29bbd5b93ebf6c77ee4dd3f62
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.