| commit | bcfdae2b5ae0607601151276c3034ff58d69adb5 | [log] [tgz] |
|---|---|---|
| author | Hugo Arès <hugo.ares@ericsson.com> | Fri Aug 12 13:18:16 2016 -0400 |
| committer | Hugo Arès <hugo.ares@ericsson.com> | Fri Aug 12 17:48:24 2016 +0000 |
| tree | 1ac5b13669d5f64845ed86741c0b2b10535f4b54 | |
| parent | df0656ed47115e50409eed4b820a4dd398113b8d [diff] |
Fix warning "close() called when useCnt is already zero" WatchConfig was closing the repository twice in getProjectWatches method. Using a try-with-resources, the method was closing the repository and the WatchConfig which was also closing the repository. WatchConfig was keeping a reference on the repository passed to the load method and closing it in the close method. VersionedMetaData default implementation of load does not keep a reference on the repository. There is no added value of keeping a reference on the repository, it's not reused anyway. Remove repository reference and no longer implement AutoCloseable. Also rename open method to read to not leave the impression that something needs to be close and to follow convention of other VersionedMetaData classes. Bug: Issue 4290 Change-Id: Ibc347b1837a6ba21f325210359ce5f10b0a3e69c
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.