commit bc4757f740c2b288cd211377e1bfb7f5d2a1cf40
author Dave Borowitz <dborowitz@google.com> Wed May 02 07:55:22 2018 -0400
committer Dave Borowitz <dborowitz@google.com> Mon May 14 14:26:50 2018 -0700
tree 4a6fd7201eaa8e2c37cd810ddf6a3be1e4c18b8f
parent 6291a6b18c01a88c318574b8cf30a3674646e20a

Clarify ChangeNotesState private/WIP/started bits

There were redundant fields in the ChangeNotesState and the contained
ChangeColumns. They properly belong in ChangeColumns, since they
correspond to actual @Columns in the Change class. Also in the Change
class, they are not nullable (they lack "notNull = false"), so remove
@Nullable in ChangeColumns as well.

A few callers were explicitly depending on the fields in
ChangeNotesState rather than in ChangeColumns; those are easily updated.
Note that the ChangeNotesState#create method always just passed in a
single value for each of these fields, which was then passed to two
different constructors, so they were always in sync.

The only time when the ChangeNotesState and ChangeColumns might
potentially be out of sync is when calling ChangeNotesState#empty, which
would pass a non-null value for these bits to the ChangeNotesState
constructor and leave the ChangeColumns null. However, this is only used
from ChangeNotes when NoteDb is disabled, in which case the
ChangeNotesState fields are never exposed to callers. In this case they
get these bits by calling the relevant methods on getChange(), which
will contain the ReviewDb change (and not have columns populated from
NoteDb via ChangeNotesState#copyColumnsTo).

Change-Id: Id4771f3e305417dc7f8d2040575d0c6746944946