Google Git
Sign in
gerrit / gerrit / bc20119203605b08c2408536c0a60e39502d42c5
commitbc20119203605b08c2408536c0a60e39502d42c5[log] [tgz]
authorOle Rehmsen <oler@google.com>Fri May 24 13:33:38 2019 +0200
committerOle Rehmsen <oler@google.com>Fri May 24 15:07:17 2019 +0200
treedb68da3e363554fa140e4f0253d8116d8dac3913
parent75eb5d316e83798a174a815c8cecce913a55ab19 [diff]
Fix callstack overflow for very large ab chunks

Turns out when you write `f(...array)`, this creates `array` on the
callstack (because it's assigned to arguments), not just a pointer to
the array, but the actual array. So if `array` is very large (say 150k
elements, as it was for an ab diff chunk in this case), then that
overflows your callstack.

I am also looking into why we actually download the 150k lines in the
first place when we only want to display the changed lines + some
context of 10 lines, but this is a quick fix that works around that
problem for now.

Change-Id: I4776b95b3db08e531d04dcabeaf15fb362f7220f
1 file changed
tree: db68da3e363554fa140e4f0253d8116d8dac3913
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. java/
  6. javatests/
  7. lib/
  8. plugins/
  9. polygerrit-ui/
  10. prolog/
  11. prologtests/
  12. proto/
  13. resources/
  14. tools/
  15. webapp/
  16. .bazelproject
  17. .bazelrc
  18. .editorconfig
  19. .git-blame-ignore-revs
  20. .gitignore
  21. .gitmodules
  22. .mailmap
  23. .pydevproject
  24. BUILD
  25. COPYING
  26. INSTALL
  27. package.json
  28. README.md
  29. SUBMITTING_PATCHES
  30. version.bzl
  31. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.