| commit | bbe7c3fc88c64e782bb06769346b61bb7fc18109 | [log] [tgz] |
|---|---|---|
| author | David Pursehouse <dpursehouse@collab.net> | Thu Sep 26 11:21:09 2019 +0900 |
| committer | David Pursehouse <dpursehouse@collab.net> | Thu Sep 26 07:29:40 2019 +0000 |
| tree | 9d1b6eef0d59bf58e7e6d923d6ecf5a69993d20a | |
| parent | 49d56d43feb80c5d05ed6f8b4f32d54d466d1b95 [diff] |
MultipleQuotaPluginsIT: Clean up and fix tests The refillsOnException test is intended to verify that when there are multiple plugins, and an exception is thrown by one of them causing the operation to fail, quota previously deducted by the ones that succeeded should be refilled. The test was instead throwing the exception from the first plugin, which means no plugins were actually deducting. It was expecting the refill on the second one, but not verifying that the call was made. Adding the call to verify() causes the test to fail, because no refill gets called. Rework the test so that the successfull deduction is done first, and the second one fails with an exception. Verify that the refill is called on the first one that was previously successfull. Also add missing calls to verify on other tests, thus confirming that the expected calls are actually occurring. Change-Id: I2cb478d0f64ad1cf66b81a051b126e1f87bcc7c7
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.