| commit | bbde672af0bce29ac62d5ec286ff98a160a22373 | [log] [tgz] |
|---|---|---|
| author | Becky Siegel <beckysiegel@google.com> | Thu Feb 08 09:50:48 2018 -0800 |
| committer | Becky Siegel <beckysiegel@google.com> | Mon Feb 12 17:36:33 2018 -0800 |
| tree | da1cf47113420ad706362ba5fb6a892cd08e5e97 | |
| parent | e32aa990ccd7b7fce710006e9a586ce839542333 [diff] |
Update comment thread creation/removal to no longer use locationRange Follow-up to https://gerrit-review.googlesource.com/c/gerrit/+/157590 which no longer used locationRange to group comments together into threads. However, locationRange was still used for a few other things including thread removal, which could result in a bug if there were two threads that had the same locationRange and the wrong one was found first. Things included in this change: 1. Determine whether a thread group exists - This is identified as it was before. The thread group now gets a commentSide attribute, as it can pass it to all of its children (the same for all). 2. Determine if a thread exists within the group for a given range in a group - The range object is now included as an attribute on the comment thread instead of the locationRange string. 3. Be able to remove a thread group - A rootId attribute is now stored on the comment thread, which is data bound to each comment. When a comment is removed, it finds the thread with the rootId within the thread group to remove. - In the event that a thread group only contains a single draft, there is no roottId. Change-Id: I4f7804ac02f4259b4964c6333d258f0fc3b29d24
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.