bb8f3b66a211aaf010afe0aaad13580ba255e290 - gerrit

commit	bb8f3b66a211aaf010afe0aaad13580ba255e290	[log] [tgz]
author	Conley Owens <cco3@android.com>	Thu Feb 02 10:44:25 2012 -0800
committer	Conley Owens <cco3@android.com>	Fri Feb 03 07:32:32 2012 -0800
tree	7b6db57b719b38d09281da6ca305015168398ef7
parent	1dd862521fe119a8584951b69aadd42d1472b800 [diff]

Make PublishAction require ownership & visiblity

Previously, PublishAction allowed reviewers of the draft change to
publish.  Correct functionality should only allow the change owner
to publish.  In addition the change visibility has to be checked,
because a change is not visible to the change owner if the project
state is HIDDEN.

In addition, the behaviour in PublishAction was inconsistent with
the behaviour in ReviewCommand.  This change makes both perform the
same check before publishing.

Change-Id: Ic306ab6a0dd49f23073f198c9dc8e9eaa90ecccc

gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeDetail.java[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeDetailFactory.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/PublishAction.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/project/ChangeControl.java[diff]
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java[diff]

6 files changed