commit bb6be2924089915f264cbcfd8ebb281408137e3d
author Dave Borowitz <dborowitz@google.com> Wed Dec 12 14:54:02 2018 -0800
committer Dave Borowitz <dborowitz@google.com> Thu Dec 13 06:49:02 2018 -0800
tree e1f7c06c8545e226cc10f8de35f9c6dda5ca1803
parent 300af25bef281a595f3b7445afefa112d858d610

Remove unused MutableNotesMigration#failOnLoadForTest

Change-Id: Ie95bf2b6c36b71ef863a804b4373fd9304fe2817

java/com/google/gerrit/server/notedb/MutableNotesMigration.java

diff --git a/java/com/google/gerrit/server/notedb/MutableNotesMigration.java b/java/com/google/gerrit/server/notedb/MutableNotesMigration.java
index eb41cbc..780b17b 100644
--- a/java/com/google/gerrit/server/notedb/MutableNotesMigration.java
+++ b/java/com/google/gerrit/server/notedb/MutableNotesMigration.java
@@ -73,10 +73,6 @@
     return set(b -> b.setDisableChangeReviewDb(disableChangeReviewDb));
   }
 
-  public MutableNotesMigration setFailOnLoadForTest(boolean failOnLoadForTest) {
-    return set(b -> b.setFailOnLoadForTest(failOnLoadForTest));
-  }
-
   /**
    * Set the in-memory values returned by this instance to match the given state.
    *

java/com/google/gerrit/server/notedb/NotesMigration.java

diff --git a/java/com/google/gerrit/server/notedb/NotesMigration.java b/java/com/google/gerrit/server/notedb/NotesMigration.java
index 28754a6..de9fc8e 100644
--- a/java/com/google/gerrit/server/notedb/NotesMigration.java
+++ b/java/com/google/gerrit/server/notedb/NotesMigration.java
@@ -84,7 +84,6 @@
                   SECTION_NOTE_DB, CHANGES.key(), PRIMARY_STORAGE, PrimaryStorage.REVIEW_DB))
           .setDisableChangeReviewDb(
               cfg.getBoolean(SECTION_NOTE_DB, CHANGES.key(), DISABLE_REVIEW_DB, false))
-          .setFailOnLoadForTest(false) // Only set in tests, can't be set via config.
           .build();
     }
 
@@ -98,8 +97,6 @@
 
     abstract boolean disableChangeReviewDb();
 
-    abstract boolean failOnLoadForTest();
-
     abstract Builder toBuilder();
 
     void setConfigValues(Config cfg) {
@@ -122,8 +119,6 @@
 
       abstract Builder setDisableChangeReviewDb(boolean disableChangeReviewDb);
 
-      abstract Builder setFailOnLoadForTest(boolean failOnLoadForTest);
-
       abstract Snapshot autoBuild();
 
       Snapshot build() {
@@ -196,15 +191,6 @@
     return snapshot.get().disableChangeReviewDb();
   }
 
-  /**
-   * Whether to fail when reading any data from NoteDb.
-   *
-   * <p>Used in conjunction with {@link #readChanges()} for tests.
-   */
-  public boolean failOnLoadForTest() {
-    return snapshot.get().failOnLoadForTest();
-  }
-
   public final boolean commitChangeWrites() {
     // It may seem odd that readChanges() without writeChanges() means we should
     // attempt to commit writes. However, this method is used by callers to know