LfsPluginServlet#load: Fix local variable hiding
The local variable `filter` was hiding the member variable of the
same name.
Change-Id: I3271f353de3e78ff0fdafc19e62946884b461520
diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/LfsPluginServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/LfsPluginServlet.java
index 6729431..482a2c0 100644
--- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/LfsPluginServlet.java
+++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/LfsPluginServlet.java
@@ -124,9 +124,9 @@
private GuiceFilter load(Plugin plugin) {
if (plugin.getHttpInjector() != null) {
final String name = plugin.getName();
- final GuiceFilter filter;
+ final GuiceFilter guiceFilter;
try {
- filter = plugin.getHttpInjector().getInstance(GuiceFilter.class);
+ guiceFilter = plugin.getHttpInjector().getInstance(GuiceFilter.class);
} catch (RuntimeException e) {
log.warn(String.format("Plugin %s cannot load GuiceFilter", name), e);
return null;
@@ -135,7 +135,7 @@
try {
ServletContext ctx =
PluginServletContext.create(plugin, "/");
- filter.init(new WrappedFilterConfig(ctx));
+ guiceFilter.init(new WrappedFilterConfig(ctx));
} catch (ServletException e) {
log.warn(String.format("Plugin %s failed to initialize HTTP", name), e);
return null;
@@ -144,10 +144,10 @@
plugin.add(new RegistrationHandle() {
@Override
public void remove() {
- filter.destroy();
+ guiceFilter.destroy();
}
});
- return filter;
+ return guiceFilter;
}
return null;
}
