| commit | ba6fd0f3b117108057a7bdc3288704f8ee1c04bd | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed May 16 15:34:33 2018 +0200 |
| committer | David Pursehouse <dpursehouse@collab.net> | Thu May 17 19:25:34 2018 +0900 |
| tree | 84b653a2ce06a71a666502ee53f79741b44848f9 | |
| parent | 7f5212239678b73b918cb2e458eaf1b541322234 [diff] |
Remove ValidationError#createLoggerSink to avoid passing around loggers Passing loggers between classes is bad and we should avoid this if possible. ValidationError#createLoggerSink required to pass in a logger just to return it back to the caller wrapped in a lambda. Remove this method and instead create the lambda directly in the caller. This brings us minimal code duplication for formatting the message, but it's better than passing the logger around. Change-Id: I6b475de50fb2a1745c16ac424e0a95d358aaaf7d Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.