| commit | ba44082bd78f295552d5a6022f07e572a0f949c3 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Tue Apr 11 18:08:03 2023 +0200 |
| committer | Ben Rohlfs <brohlfs@google.com> | Tue Apr 18 10:40:43 2023 +0200 |
| tree | cb9b54ab21eed82211408ff0b1dcb71c91c748c2 | |
| parent | bf1cf3eff669ba5eb5ca65ef66317bb1b73ece7c [diff] |
Treat unsaved comment as a DraftInfo entity
This means removing the `UnsavedInfo` type and moving control of unsaved
drafts into the comment model. Before this change unsaved drafts were
just a local state of comment components.
The motivation for this change comes from implementing optimistic
updates. For that we need to be able to go back from SAVING state to
UNSAVED in case of an error. With the current implementation that was
not really possible, or would at least have created a great mess.
The simplification in `gr-comment-thread` and `gr-diff-host` proves that
this change is also desirable for other reasons. It is much easier for
these two components to just consume everything from the model instead
of treating unsaved and saved drafts separately.
One challenge was how to deal with the `id` of a draft. The server sets
the `id` once it was saved, but until then we still need some kind of
identification, so for unsaved drafts we create a `client_id` and use
that for identifying the draft, even after it has been saved.
The type system for `CommentInfo` and `DraftInfo` has also cleaned up a
bit. Sorry for the noise of replacing some `PathToCommentsInfoMap` by
`{[path: string]: CommentInfo[]}` etc.
Release-Notes: skip
Google-Bug-Id: b/262228572
Change-Id: I1bd03ad58779d108bca0a22c517d27557aa62bbf
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.