| commit | b94e3ac6bbf022773ac88466b2a2aaa7b1c338f4 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed Sep 07 09:41:53 2022 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Wed Sep 07 08:41:14 2022 +0000 |
| tree | 0fd07cb36cd2a88f04a922edbf91f42a85408058 | |
| parent | 8b845a60d8071114914c6ce5f56ae2c3fcfb6bbd [diff] |
ApprovalsUtil: Use internal user to parse copy conditions If the copy condition contains a UserInPredicate (approverin or uploaderin) the copy condition can only be parsed by users that can see the referenced groups. This means to ensure that the parseability doesn't depend on the current user we need to open a request context with the internal user when parsing copy conditions. The internal user can see all groups and hence parsing the copy condition can never fail due to group visibility limitations. ApprovalCopier already used the internal user for parsing copy conditions when copying approvals, but when formatting the copied/outdated votes in ApprovalsUtil we did use the calling user for parsing the copy condition. Due to this the change message with the copied/outdated votes could wrongly say that a copy condition is not parseable although it actually is. In this case the copying of the approvals worked correctly (since ApprovalCopier already used the internal user) but only the change message was incorrectly saying that the copy condition was non-parseable. Bug: Google b/243441912 Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: If5a48316dcdb604797140cf33b3c1e44f0e37400 Release-Notes: skip
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.