commit | b84c227162d4835c6ea928178fe9cc619d6e27c2 | [log] [tgz] |
---|---|---|
author | Dave Borowitz <dborowitz@google.com> | Thu Aug 27 11:33:24 2015 -0400 |
committer | Dave Borowitz <dborowitz@google.com> | Fri Aug 28 14:08:58 2015 -0400 |
tree | 32753ab34d9dc25858dff1671ae514dad6da3c74 | |
parent | 73cfbe65298670ee4e26593d515bffd2c383df93 [diff] |
Remove contact store functionality Class loading of PGP functionality has never worked out of the box, from which we can conclude that this feature is unused in the wild. PGP functionality has never been located in bcprov-*.jar, at least as long as the original library download configuration has existed. 3bccd773 points to bcprov-jdk16-144.jar, which does not contain PGP classes: $ curl -sOL http://www.bouncycastle.org/download/bcprov-jdk16-144.jar && jar tf bcprov-jdk16-144.jar | grep -i pgp org/bouncycastle/crypto/modes/OpenPGPCFBBlockCipher.class org/bouncycastle/crypto/modes/PGPCFBBlockCipher.class Even before that commit, in 44671f5c, we were checking for the presence of PGPPublicKey.class in the havePGP() helper method. This functionality at one point was used by Google to implement CLA checking, but that used a different build system and so did not see the breakage caused by incorrect library download configuration. These days, Google does not even use the same contact store mechanism for googlesource.com; CLAs are managed using a different system. Also delete UI associated with storing contact information. Although it was possible to configure a CLA to prompt the user for contact information, looking at the logic in AccountSecurityImpl, this info was dropped on the floor unless a ContactStore was configured. As we know, this was never the case, so claiming to store encrypted contact information in the UI was basically a lie. Similarly, the contactFiledOn field in Account was only set in the same ContactStore-enabled codepath, so we can kill that as well. Change-Id: I497cd374566c7d56262dafeeb96e4612fee54e8f
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && buck build all
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.