commit b6e53e6ec3d09e7e6a8dd328f60ccee243f0aa57
author Ben Rohlfs <brohlfs@google.com> Fri Feb 07 07:52:52 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri Feb 07 07:52:52 2020 +0000
tree 80042c899d97e067640455f55e4ce79de86686d7
parent ba755ab1d0fbccddc2c5e3ecafa7fe82ccc8d8ee
parent abed189461e92b0df072c2b8d3b880fceefe0abc

Merge "Fix error when try assign on getter with existing property"

polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface.js

diff --git a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface.js b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface.js
index 6f9268c..4286fc9 100644
--- a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface.js
+++ b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface.js
@@ -147,13 +147,16 @@
       //
       // This clone and getter can be removed after plugins migrate to use
       // info.mergeable.
-      const change = Object.assign({
+      //
+      // assign on getter with existing property will report error
+      // see Issue: 12286
+      const change = Object.assign({}, detail.change, {
         get mergeable() {
           console.warn('Accessing change.mergeable from SHOW_CHANGE is ' +
               'deprecated! Use info.mergeable instead.');
-          return detail.info.mergeable;
+          return detail.info && detail.info.mergeable;
         },
-      }, detail.change);
+      });
       const patchNum = detail.patchNum;
       const info = detail.info;