commit | b682dae9201cdca524860d7af0710edb2cb4cb08 | [log] [tgz] |
---|---|---|
author | Patrick Hiesel <hiesel@google.com> | Mon Jul 09 13:24:37 2018 +0200 |
committer | Patrick Hiesel <hiesel@google.com> | Tue Jul 10 09:28:03 2018 +0000 |
tree | bb18b188afcddf3504578e834619f34eb959fb46 | |
parent | 51b5df33af0f810dde4903631161c0fee6d7ca76 [diff] |
Remove PermissionBackend.*#user() This commit removes the user() method from all PermissionBackend subclasses. This method just encourages callers to pass around a PermissionBackend when they really want to pass around a CurrentUser and/or ChangeNotes. Passing around heavy objects that represent a subsystem for the benefit of getting smaller objects from it is an anti-pattern. We had this issue at a larger scale with {Ref,Project,Change}Control that were often just passed around to have a user and/or entity information. Removing the user() methods should prevent that. This refactoring also uncovered some wrongdoing that we already had in the code as a direct result from passing PermissionBackends around (see previous commit). Removing user() comes at the (small) const that every PermissionBackend has to implement #testCond by itsself, which seems fair and like a better pattern in general. Change-Id: Ibae1fc25e51228dca2acaf0faec76beee539da01
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.