| commit | b615c84ad8d3250f851aa9c80938c08422b48975 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed Jul 31 16:43:44 2019 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Wed Jul 31 16:44:48 2019 +0200 |
| tree | aa16dfeeef643e711ac65a0364dc10fdf7c54108 | |
| parent | 42b47b11c4b0dc79cb895cebeb241fcdf279b918 [diff] |
Consider change ETag computations from plugins when computing ETag for actions Change I358e3d4fb added an extension point that allows plugins to contribute to the ETag computation of changes. One case where plugins need to contribute to the ETag computation is if they implement a SubmitRule which is based on plugin data, because only then it is guaranteed that callers always see current submittable information in ChangeInfo. In the case where a plugin implements a SubmitRule it is also important to include the change ETag computations from plugins when the ETag for revision actions is computed because the revision actions decide whether the 'Submit' button should be shown. If change ETag computations from plugins are not considered when the ETag for the revision actions is computed it can happen that the submittable information in ChangeInfo disagrees with the presence/absense of the 'Submit' button. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Id83533e7b67cc82737feb6615c8ec9277b676d1b
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.