| commit | b53ae42b99a65748b04cce8cf27b85db8f3cc2fa | [log] [tgz] |
|---|---|---|
| author | Milutin Kristofic <milutin@google.com> | Thu Jun 25 10:58:11 2020 +0000 |
| committer | Milutin Kristofic <milutin@google.com> | Thu Jun 25 12:59:55 2020 +0200 |
| tree | 3fdc9042cc2963ba9c0934c8cf4c4706aa4315e7 | |
| parent | 625532a36d387a10b089a13fe7770888c1d7fd40 [diff] |
Revert "Fix linking on subject column" This reverts commit 625532a36d387a10b089a13fe7770888c1d7fd40. Reason for revert: CMD + Click stopped working Change-Id: Ie3eb36202cd9f3aaef659328720f35d8c8f71b49
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js index 172e444..a3fe990 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js
@@ -105,12 +105,6 @@ }); } - _handleContentClick(e) { - e.preventDefault(); - e.stopPropagation(); - GerritNav.navigateToChange(this.change); - } - _computeChangeURL(change) { return GerritNav.getUrlForChange(change); }
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_html.js b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_html.js index 36f84f7..5ff7dde 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_html.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_html.js
@@ -44,7 +44,13 @@ text-overflow: ellipsis; white-space: nowrap; width: 100%; - cursor: pointer; + } + .content a { + display: block; + overflow: hidden; + text-overflow: ellipsis; + white-space: nowrap; + width: 100%; } .comments, .reviewers { @@ -123,7 +129,7 @@ hidden$="[[isColumnHidden('Subject', visibleChangeTableColumns)]]" > <div class="container"> - <div class="content" on-click="_handleContentClick"> + <div class="content"> <a title$="[[change.subject]]" href$="[[changeURL]]"> [[change.subject]] </a>