| commit | b53581be87466d663e8c1e8058e58a9a97c2dfb4 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Mon Apr 08 08:25:32 2019 -0700 |
| committer | Dave Borowitz <dborowitz@google.com> | Mon Apr 08 09:22:36 2019 -0700 |
| tree | db54b88bc502373247c9912341a57af88d944eb4 | |
| parent | bdeca27b67e87afa1d831a37deceeb7ee1bff784 [diff] |
Fix plugin-provided change query operators and add test I9a4088d2 was intended to be a no-op refactoring, but unfortunately it broke the implementation of plugin-provided change query operators, which were previously untested. Add a test of the behavior as documented in dev-plugins.txt. The test failure was caused by a private method that mutates the opFactories map, which is intended to be immutable for the lifetime of a ChangeQueryBuilder. The old implementation wasn't broken per se, because the private method was called only from the constructor, but it was not trivial to reason about (hence why the subsequent breakage slipped through review). Instead of reinstating the mutable field, push the DynamicMap iteration into the QueryBuilder constructor. In order to prove that the DynamicMap iteration is typesafe, introduce a new type parameter to QueryBuilder, allowing us to remove the warning suppression on the constructor. Change-Id: I06cf253c82bf03bc97dcba08ca7d494011c88384
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.