commit b5099530084deb61fcb9e60314579dd0daed79b5
author David Ostrovsky <david@ostrovsky.org> Sat May 06 06:35:48 2017 +0200
committer Kasper Nilsson <kaspern@google.com> Tue May 09 11:14:21 2017 -0700
tree d1690fc68ccc93a01de0100b5715d84434d03495
parent 452a5c6fa8d8c150147972bc8031776c4a4d474c

maven_jar compatibility to rules_closure#java_import_external

This is a preparation change for bumping rules_closure to the HEAD, that
we need to make transpilation from ES6 to ES5 actually work.

Since this commit: [1] rules_closure moved from using maven_jar to home
grown java_import_external rule. However, this introduced subtle
incompatibility issue: [2], because java_import_external mounts external
dependency under the root directory and not under the @foo/jar directory,
like native and our own custom maven_jar rules are doing.

This leads to the incompatibility, of how the external dependency are
consumed, with the consequence, that artifacts are not found by the
rule_closure rules, that were fetched with our own maven_jar rule.

To rectify, extend our maven_jar rule and generate additional BUILD
file in the root folder of the external dependency directory and alias
it to the real one generated in the @foo/jar directory.

For example, this BUILD file is now generated in root directory:

  alias(
      name = "javax_inject",
      actual = "@javax_inject//jar",
  )

This allows us to omit additional fetching of already fetched artifacts
that are needed by rules_closures rules and let them reference to the
downloaded artifacts in gerrit build.

There is one complication though: java_import_external accepts deps
attribute, in which case the artifacts with dependencies are not
compatible with our own maven_jar custom rule, that doesn't support
transitive dependencies. That means that we can only reuse such
artifacts from the rules_closure build that don't have dependencies.

Another problem, why we can't reuse even such artifacts that don't have
dependencies specified, is different naming convention. gerrit uses
simple names, like jsr305, but rules_closure is using canonical artifact
names, e.g.: com_google_code_findbugs_jsr305, so that we get:

* external/jsr305/jar/jsr305-3.0.1.jar # gerrit
* external/com_google_code_findbugs_jsr305/jsr305-2.0.3.jar # closure

Effectively, right now this change let us only reuse 3 common
dependencies:

* aopalliance
* javax_inject
* args4j

Because the same name, we must solve the collision problem here. Another
considered alternatives to this change would be:

1. Ask rules_closure project to migrate to consuming their dependencies
from @foo/jar directory, so that it is compatible with native and custom
maven_jar rules
2. Consume common dependencies in gerrit with rule_closure's own
java_import_external rule

[1] https://github.com/bazelbuild/rules_closure/commit/a47cc063d39b3958f31b4c5a992741020fd9ee3e
[2] https://github.com/bazelbuild/rules_closure/issues/200

Change-Id: I31e6b863e43adaa1f983a8a9da1675f02cb803f8