commit b3ed945cd511d007ab16ab54d99d3fff1c7fe5fa
author Ben Rohlfs <brohlfs@google.com> Fri Oct 28 17:20:50 2022 +0200
committer Paladox none <thomasmulhall410@yahoo.com> Mon Oct 31 23:50:49 2022 +0000
tree afe29079449c96210c5afc112e7f59339aff6c24
parent 9da9e49a17bfea2bb032d56626c8f53b0676496d

Disable 'Save' button for empty comments even when 'resolved' changes

Release-Notes: skip
Google-Bug-Id: b/255288198
Change-Id: If5c7c915a1ef19439c1fd769e1c9b5679cd38e2c
(cherry picked from commit db357a12eb41255a6d6ac24be810e1519def61bb)

polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts

diff --git a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts
index 9db3693..9e8264c 100644
--- a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts
+++ b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts
@@ -1077,7 +1077,6 @@
   isSaveDisabled() {
     assertIsDefined(this.comment, 'comment');
     if (this.saving) return true;
-    if (this.comment.unresolved !== this.unresolved) return false;
     return !this.messageText?.trimEnd();
   }
 

polygerrit-ui/app/elements/shared/gr-comment/gr-comment_test.ts

diff --git a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment_test.ts b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment_test.ts
index 1b48658..2293619 100644
--- a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment_test.ts
+++ b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment_test.ts
@@ -528,9 +528,11 @@
       await element.updateComplete;
       assert.isTrue(element.isSaveDisabled());
 
+      // After changing the 'resolved' state of the comment the 'Save' button
+      // should stay disabled, if the message is empty.
       element.unresolved = false;
       await element.updateComplete;
-      assert.isFalse(element.isSaveDisabled());
+      assert.isTrue(element.isSaveDisabled());
 
       element.saving = true;
       await element.updateComplete;