| commit | b2de7f8ad421ffacde3a58549ab7c18f7fc47eb9 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Tue Oct 02 10:32:33 2018 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Tue Oct 02 11:45:50 2018 +0200 |
| tree | 15cdc9e169024139dade54fca84db292ad1a5325 | |
| parent | 40a43748b10e4e452e7768c1d407370a6daa8c08 [diff] |
PostReview: Fix permission check for setting wip/ready The work-in-progress flag on a change can be toggled by the change owner, the project owner and admins. The SetWorkInProgress and SetReadyForReview REST endpoints properly checked the permissions and also the corresponding UI actions were enabled/disabled based on these permission. However when the work-in-progress flag was toggled from PostReview the request was denied if the user was a non-change-owner. As result of this project owners and admins could see the action in PolyGerrit but clicking on it failed. To fix this the permission checks are now implemented by a static method in WorkInProgressOp that can be reused from all the places. This changes the response code for PostReview if a user is not allowed to toggle the work-in-progress flag to 403 Forbidden. Previously it was returning 400 Bad Request which was wrong since 400 Bad Request should only be returned if the request has a malformed syntax, required input fields are missing or mutally exclusive input fields are used together, but not if permissions are missing. Bug: Issue 9787 Change-Id: Ica169002e36c1d8070c403a3d7103a6f70060c28 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.