A11y - Improvements on dashboard page - Change size title and screen reader label from `+2, -1` to `added 2, removed 1 lines`. It should be clearer. - Skip `,` by screen reader in Reviewers column (attention set) Change-Id: I3fb5994b827a6923c25849a782d85f9180e2ab7a
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js index cb1905b..b2ce8fd 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js
@@ -214,7 +214,7 @@ isNaN(change.insertions + change.deletions)) { return 'Size unknown'; } else { - return `+${change.insertions}, -${change.deletions}`; + return `added ${change.insertions}, removed ${change.deletions} lines`; } }
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_html.js b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_html.js index 48aab4c..0fd3030 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_html.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_html.js
@@ -200,7 +200,7 @@ change="[[change]]" account="[[reviewer]]" ></gr-account-link - ><span class="lastChildHidden">, </span> + ><span class="lastChildHidden" aria-hidden="true">, </span> </template> <template is="dom-if" if="[[_computeAdditionalReviewersCount(change)]]"> <span title="[[_computeAdditionalReviewersTitle(change, config)]]">
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js index e49da7e..6d51310 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js
@@ -233,7 +233,7 @@ assert.equal(element._computeSizeTooltip({ insertions: 1, deletions: 2, - }), '+1, -2'); + }), 'added 1, removed 2 lines'); }); test('TShirt sizing', () => {