commit b1d685db437ea3b58f9066f6c696e27db2588bd3
author Dave Borowitz <dborowitz@google.com> Tue Oct 29 11:19:35 2013 -0700
committer David Pursehouse <david.pursehouse@sonymobile.com> Thu Oct 31 07:18:42 2013 +0000
tree 709e77e9a36568a602aee3696c89ba045c66e7c7
parent c9b686056eeb344f21bdf259cc000ebd4fa8af65

PatchListCacheImpl: explicitly check for null revision

Change-Id: Ib88d104ebd288e16ee2499ca93cecd4a8b9e2b2a
(cherry picked from commit 8909bc4c2c94ed80bf315a286aadaa56ec77ebd6)

gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java
index 967e6a7..7b7c731 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java
@@ -90,6 +90,10 @@
       throws PatchListNotAvailableException {
     final Project.NameKey projectKey = change.getProject();
     final ObjectId a = null;
+    if (patchSet.getRevision() == null) {
+      throw new PatchListNotAvailableException(
+          "revision is null for " + patchSet.getId());
+    }
     final ObjectId b = ObjectId.fromString(patchSet.getRevision().get());
     final Whitespace ws = Whitespace.IGNORE_NONE;
     return get(new PatchListKey(projectKey, a, b, ws));