| commit | b1b9b0a30fb8423ca8913796c8d8e1375b77b254 | [log] [tgz] |
|---|---|---|
| author | Paladox none <thomasmulhall410@yahoo.com> | Tue Jul 30 20:48:37 2019 +0000 |
| committer | Paladox none <thomasmulhall410@yahoo.com> | Thu Aug 01 12:59:30 2019 +0000 |
| tree | c1b91a53b360f0382631f9519b0829a2cd2b7837 | |
| parent | e17699d3280280bc6758ac0de32dbafbf85b5005 [diff] |
Fix "stopEdit" not disappearing under Polymer 2 When you click "edit", you are given the option to press "Stop Editing", but when you click "Stop Editing". The button is still shown (even though 'edit' is now shown). To fix this we assign a fake value to notifyPath. This works around the issue under Polymer 2. See [1]. [1] https://github.com/Polymer/polymer/issues/2631#issuecomment-325131305 Change-Id: I39be6483f3a8d36cbd22ee4a5fa59374c48ca8af
diff --git a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js index 83a454b..5a35c43 100644 --- a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js +++ b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js
@@ -575,7 +575,9 @@ _deleteAndNotify(actionName) { if (this.actions[actionName]) { delete this.actions[actionName]; - this.notifyPath('actions.' + actionName); + // We assign a fake value of 'false' to support Polymer 2 + // see https://github.com/Polymer/polymer/issues/2631 + this.notifyPath('actions.' + actionName, false); } },