Google Git
Sign in
gerrit / gerrit / b158469d2d48a356c4b07fe3e58b54da9f8303b1
commitb158469d2d48a356c4b07fe3e58b54da9f8303b1[log] [tgz]
authorEryk Szymanski <eryksz@gmail.com>Mon Jul 18 12:25:15 2016 +0200
committerEryk Szymanski <eryksz@gmail.com>Mon Jul 18 12:25:15 2016 +0200
tree2f5764c6e999244cd9c6673c668f5006ed37b91d
parentbcec8707583029e997963c4a224c393e520c1f78 [diff]
Catch NumberFormatException on invalid request

This prevents NumberFormatException in RestApiServlet on queries like:

GET /gerrit/changes/?n=25&O=815%20oR%209%3D9%20%2B%201

Which results with

ERROR| RestApiServlet | Error in GET
/gerrit/changes/?n=25&O=815%20oR%209%3D9%20%2B%201
java.lang.NumberFormatException: For input string: "815 oR 9=9 + 1"

plus the stack trace without this patch.

Change-Id: I631c51e768095998f87d861fd09d0394f23c81c1
Signed-off-by: Eryk Szymanski <eryksz@gmail.com>
1 file changed
tree: 2f5764c6e999244cd9c6673c668f5006ed37b91d
  1. .settings/
  2. bucklets/
  3. contrib/
  4. Documentation/
  5. gerrit-acceptance-framework/
  6. gerrit-acceptance-tests/
  7. gerrit-antlr/
  8. gerrit-cache-h2/
  9. gerrit-common/
  10. gerrit-extension-api/
  11. gerrit-gpg/
  12. gerrit-gwtdebug/
  13. gerrit-gwtexpui/
  14. gerrit-gwtui/
  15. gerrit-gwtui-common/
  16. gerrit-httpd/
  17. gerrit-launcher/
  18. gerrit-lucene/
  19. gerrit-main/
  20. gerrit-oauth/
  21. gerrit-openid/
  22. gerrit-patch-commonsnet/
  23. gerrit-patch-jgit/
  24. gerrit-pgm/
  25. gerrit-plugin-api/
  26. gerrit-plugin-archetype/
  27. gerrit-plugin-gwt-archetype/
  28. gerrit-plugin-gwtui/
  29. gerrit-plugin-js-archetype/
  30. gerrit-prettify/
  31. gerrit-reviewdb/
  32. gerrit-server/
  33. gerrit-sshd/
  34. gerrit-util-cli/
  35. gerrit-util-http/
  36. gerrit-util-ssl/
  37. gerrit-war/
  38. lib/
  39. plugins/
  40. polygerrit-ui/
  41. ReleaseNotes/
  42. tools/
  43. website/
  44. .bazelrc
  45. .buckconfig
  46. .buckversion
  47. .editorconfig
  48. .gitignore
  49. .gitmodules
  50. .mailmap
  51. .pydevproject
  52. .watchmanconfig
  53. BUCK
  54. COPYING
  55. INSTALL
  56. README.md
  57. SUBMITTING_PATCHES
  58. VERSION
  59. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Buck and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && buck build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.