Buck: Remove no-op gwt_jar attribute in prebuilt_jar
If there is a prebuilt jar that defines a different binary jar from
the gwt jar, building a normal java binary will use the binary jar,
and building a gwt binary will use the gwt jar.
If a target defines them both to be the same there's no need to define
the gwt jar, as it will default to being the binary jar.
The actual use case where it is needed when there is an alternative GWT
implementation of a Java library. Specifically, when there is one
implementation that contains JSNI, and one implementation that contains
an implementation that cannot be translated to JS by the GWT compiler:
prebuilt_jar(
name = 'guava',
binary_jar = 'guava-17.0.jar',
source_jar = 'guava-17.0-sources.jar',
gwt_jar = 'guava-gwt-17.0.jar',
visibility = [
'PUBLIC',
],
)
Change-Id: Ibbc7ea56aad6885625e652b2dedbcdfe038735d7
diff --git a/gerrit-gwtui/gwt.defs b/gerrit-gwtui/gwt.defs
index b1963a7..85553f2 100644
--- a/gerrit-gwtui/gwt.defs
+++ b/gerrit-gwtui/gwt.defs
@@ -124,7 +124,6 @@
prebuilt_jar(
name = '%s_gwtxml_lib' % gwt_name,
binary_jar = ':%s_gwtxml_gen' % gwt_name,
- gwt_jar = ':%s_gwtxml_gen' % gwt_name,
)
gwt_binary(
name = gwt_name,
