Addresses unit-test flakiness in Safari
The gr-settings-view tests partially relied on timing for evaluating the
tests. If a browser acted too slowly in executing the test, the tests
would occasionally fail. This change removes timing from the test and
instead listens to a promise that the settings view now provides.
A gr-error-manager test relied on flushing the DOM for a response
content promise to be resolved. In Safari, this would frequently execute
out of the expected order. This change waits for the promise itself to
complete before continuing the test.
Change-Id: Id93ccc44bcf3baecdba53058e42dcebccfa4c326
diff --git a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.html b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.html
index 8930544..70b7c1c 100644
--- a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.html
+++ b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.html
@@ -123,7 +123,7 @@
element = fixture('basic');
// Allow the element to render.
- element.async(done, 1);
+ element._loadingPromise.then(done);
});
test('calls the title-change event', function() {
