| commit | 427b0d8c25c309aba28c21d33adceba9087bf5a9 | [log] [tgz] |
|---|---|---|
| author | Gal Paikin <paiking@google.com> | Tue Nov 30 16:39:20 2021 +0100 |
| committer | Gal Paikin <paiking@google.com> | Tue Nov 30 16:39:20 2021 +0100 |
| tree | c4300a4f5f9b7c7b4195b9693973386b01f5adc7 | |
| parent | 7e4ef55fe2e0530b36f1a4dfca0478d80aa8ee25 [diff] |
Avoid computing votes on read: read from storage Until now, we computed votes using ApprovalInference. This took into account copied votes. This was not efficient since it had to take into account copied votes from very old patchsets. E.g, votes sometimes need to be copied from ps1 to ps10. Later, we introduced ApprovalCache that saved some of the computations in Ie53fbce4e. This improved the latency. As a long term solution, we then introduced persisting copied votes in NoteDb in Ia1ab9b3c. However, we didn't start using the persisted copied votes yet. The reason for only using the persisted copied votes a version later in upstream Gerrit, is to ensure users have enough time between versions. Older votes will be lost. As a follow-up we will also remove ApprovalCache since it's no longer used. Technical detail: We put labelNormalizer in ApprovalsUtil to ensure we normalize labels (aka remove non existing labels). This is necessary since we don't want to return (usually) votes to labels that don't exist. We also wrote a test for deleting reviewer which should delete all votes. We should delete copied votes as well, so this is verified by a test. Change-Id: If95c0f8b0466e6853932f13ceba740c8f2e5307b
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.