ChangeInfo: Serve reviewers when LABELS are requested With the launch of attention set, the UI started requesting DETAILED_LABELS to populate reviewers on dashboards. Unfortunately, this also computes which reviewer is allowed to vote on any label. This check requires getting the group memberships for each reviewer. This operation is expensive when external group backends are used. In this change, we expose reviewers also when LABELS are requested. This will enable the UI to stop requesting DETAILED_LABELS and request only the cheaper LABELS instead. Change-Id: I2fb5da919da28c99766109b263124f2cdac5e585
diff --git a/Documentation/rest-api-changes.txt b/Documentation/rest-api-changes.txt index d128613..43c3b9e 100644 --- a/Documentation/rest-api-changes.txt +++ b/Documentation/rest-api-changes.txt
@@ -216,15 +216,18 @@ [[labels]] -- * `LABELS`: a summary of each label required for submit, and - approvers that have granted (or rejected) with that label. + approvers that have granted (or rejected) with that label + as well as all reviewers by state, and reviewers that may + be removed by the current user. -- [[detailed-labels]] -- * `DETAILED_LABELS`: detailed label information, including numeric values of all existing approvals, recognized label values, values - permitted to be set by the current user, all reviewers by state, and - reviewers that may be removed by the current user. + permitted to be set by any reviewer and the change owner, all + reviewers by state, and reviewers that may be removed by the + current user. -- [[current-revision]] @@ -6412,7 +6415,8 @@ |`removable_reviewers`|optional| The reviewers that can be removed by the calling user as a list of link:rest-api-accounts.html#account-info[AccountInfo] entities. + -Only set if link:#detailed-labels[detailed labels] are requested. +Only set if link:#labels[labels] or +link:#detailed-labels[detailed labels] are requested. |`reviewers` |optional| The reviewers as a map that maps a reviewer state to a list of link:rest-api-accounts.html#account-info[AccountInfo] entities. @@ -6421,13 +6425,15 @@ `CC`: Users that were added to the change, but have not voted. + `REMOVED`: Users that were previously reviewers on the change, but have been removed. + -Only set if link:#detailed-labels[detailed labels] are requested. +Only set if link:#labels[labels] or +link:#detailed-labels[detailed labels] are requested. |`pending_reviewers` |optional| Updates to `reviewers` that have been made while the change was in the WIP state. Only present on WIP changes and only if there are pending reviewer updates to report. These are reviewers who have not yet been notified about being added to or removed from the change. + -Only set if link:#detailed-labels[detailed labels] are requested. +Only set if link:#labels[labels] or +link:#detailed-labels[detailed labels] are requested. |`reviewer_updates`|optional| Updates to reviewers set for the change as link:#review-update-info[ReviewerUpdateInfo] entities.