Use display name if it is set for getAccountDisplayName Display name is not being shown correctly in account suggestions because we are not showing display name, only name. Some users have display name set to "(DO NO USE)" to ensure that people don't pick the wrong account as a reviewer. We should respect this in getAccountDisplayName. Google-Bug-Id: b/219952599 Release-Notes: skip Change-Id: Ic8d875009ff47cac5c6e5c538134adf7341b70e5
diff --git a/polygerrit-ui/app/utils/display-name-util.ts b/polygerrit-ui/app/utils/display-name-util.ts index b509943..7c39e1a 100644 --- a/polygerrit-ui/app/utils/display-name-util.ts +++ b/polygerrit-ui/app/utils/display-name-util.ts
@@ -55,7 +55,7 @@ config: ServerInfo | undefined, account: AccountInfo ) { - const reviewerName = getUserName(config, account); + const reviewerName = getDisplayName(config, account); const reviewerEmail = _accountEmail(account.email); const reviewerStatus = account.status ? '(' + account.status + ')' : ''; return [reviewerName, reviewerEmail, reviewerStatus]
diff --git a/polygerrit-ui/app/utils/display-name-util_test.ts b/polygerrit-ui/app/utils/display-name-util_test.ts index 8e9f789..2f938a5 100644 --- a/polygerrit-ui/app/utils/display-name-util_test.ts +++ b/polygerrit-ui/app/utils/display-name-util_test.ts
@@ -194,6 +194,18 @@ ); }); + test('getAccountDisplayName - account with display name', () => { + assert.equal( + getAccountDisplayName(config, { + display_name: 'Display Name', + name: 'Some name', + email: 'my@example.com' as EmailAddress, + status: 'OOO', + }), + 'Display Name <my@example.com> (OOO)' + ); + }); + test('getGroupDisplayName', () => { assert.equal( getGroupDisplayName({