commit | ac0b4fce214b1ac5678da3ead8e36aa585e72c82 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Thu Oct 21 13:02:45 2021 +0200 |
committer | Edwin Kempin <ekempin@google.com> | Thu Oct 21 15:50:46 2021 +0200 |
tree | 5a58545a3eed729b418d216bbd3c60324110db21 | |
parent | c1427ceedcf54408a0bf10f84bb3f1c8508665bc [diff] |
Add integration test to validate submit requirements on upload The tests fetch refs/meta/config, edit submit requirements in project.config and then push back the changes to refs/meta/config. Pushing a project.config file to refs/meta/config triggers a validation of the project configuration. If validation errors are found the push is rejected. The new test verifies that validation errors in submit requirements make the push fail as expected. This change doesn't add any new validations for submit requirements, but only tests the ones which are already present (check for conflicting submit requirements, check for mandatory submittability expression). Follow-up changes intend to add further validation checks. The error messages for the existing validations are slightly changed: * The message parts that say that a submit requirement is skipped are dropped, as this is not correct. The submit requirement is not skipped, but rather rejected. * Use single quotes around submit requirement names. Just because this makes the code more readable than using double quotes which have to be escaped. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I5f9be5df60c3ff8de70554256d07ed760af948df
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.