Google Git
Sign in
gerrit / gerrit / ab4e453b5ff4b00df72d1efb8320b69953f00643
commitab4e453b5ff4b00df72d1efb8320b69953f00643[log] [tgz]
authorLuca Milanesio <luca.milanesio@gmail.com>Thu Jan 20 21:10:37 2022 +0000
committerLuca Milanesio <luca.milanesio@gmail.com>Thu Jan 20 21:17:01 2022 +0000
tree381ec6e7e419da75613c30f3d9ebd4e49080fb92
parentac476b9d51266e3e904a5584c8e0eba90a2a3f8a [diff]
Bump SLF4J to 1.7.33 for including Reload4J binding

The SLF4J's MDC  has been broken since the swap
of Log4J with Reload4J done in Change I1d01ab0a5d3a.

Although Reload4J is supposed to be a replacement for Log4J
some of its internals are different with regards to the
MDC's initialization.

SF4J assumes that the MDC's structure is the one implemented
in Log4J; however, when the Reload4J classes are used, it\
fails with java.lang.NoSuchFieldError: tlm.

The failure is subtle because it appears only when one of
the classes Gerrit's plugins directly refers
to the MDC. The Gerrit build instead does not instantly
fail, even if there is a mismatch of SLF4J binding.

The SLF4J project has created a specific binding for Reload4J
that is available from v1.7.33 (see [1]), hence the bump
of release and the swap of Log4J with Reload4J also on the
binding side.

[1] https://mvnrepository.com/artifact/org.slf4j/slf4j-reload4j/1.7.33

Bug: Issue 15590
Change-Id: Icef4a845d5a9539e396698853e810334ea6b036b
1 file changed
tree: 381ec6e7e419da75613c30f3d9ebd4e49080fb92
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.