Google Git
Sign in
gerrit / gerrit / a83fea5bf98681c5f8dcf0c1610f0774de5a6973
commita83fea5bf98681c5f8dcf0c1610f0774de5a6973[log] [tgz]
authorBen Rohlfs <brohlfs@google.com>Thu Jul 04 15:56:01 2024 +0200
committerBen Rohlfs <brohlfs@google.com>Thu Jul 04 14:49:44 2024 +0000
treeb83c53eb95af4ddeadb8f52e52c32d0442d3996b
parent389bddc2480d7ca965db1cb5dad959671d12cfa4 [diff]
Resolve competition of comment range color and token color

The typical user interaction for range commenting is to drag the mouse
to select and then press `c`, and then start typing without further
mouse movement. This results in the token highlighting still being
applied while the user types the comment. If the user happens to only
comment on a substring of a token, then they cannot see the comment
range at all while typing the comment. This was reported in the
referenced issue.

Prefering the background color of the comment range highlight is a bit
tricky, because the highlights are not applied to the same element, and
the token element is always the inner element, and thus "wins". So we
have to adapt the css rule to make sure that there is not comment
highlighting element between `gr-diff-text` and the token.

We are also adapting the comment range hightlighting colors a tiny bit,
because it was quite impossible to see the difference of the token
highlight color and `--diff-highlight-range-hover-color` is light theme.

Screenshots https://imgur.com/a/lYQRj8w

Release-Notes: skip
Google-Bug-Id: b/349651135
Change-Id: I26731a60a9e24af0d101ec5072b5188c1366a095
4 files changed
tree: b83c53eb95af4ddeadb8f52e52c32d0442d3996b
  1. .github/
  2. .settings/
  3. .ts-out/
  4. antlr3/
  5. contrib/
  6. Documentation/
  7. e2e-tests/
  8. java/
  9. javatests/
  10. lib/
  11. modules/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. proto/
  17. resources/
  18. tools/
  19. webapp/
  20. polymer-bridges
  21. .bazelignore
  22. .bazelproject
  23. .bazelrc
  24. .bazelversion
  25. .editorconfig
  26. .git-blame-ignore-revs
  27. .gitignore
  28. .gitmodules
  29. .gitreview
  30. .mailmap
  31. .pydevproject
  32. .zuul.yaml
  33. BUILD
  34. COPYING
  35. INSTALL
  36. Jenkinsfile
  37. MODULE.bazel
  38. package.json
  39. README.md
  40. SUBMITTING_PATCHES
  41. version.bzl
  42. web-dev-server.config.mjs
  43. WORKSPACE
  44. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.