| commit | a7149389654124df1dd3a18b72ab95058251968f | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Thu Jan 28 15:20:49 2016 -0500 |
| committer | Edwin Kempin <ekempin@google.com> | Tue Feb 02 08:48:24 2016 +0100 |
| tree | fa266859113394d4024a9a1be695dad97eb3cf79 | |
| parent | b3d7f7328e03b924d4236ff27b0425b90767758e [diff] |
PatchSet: Always use non-null Lists for groups Although groups may be "missing" due to patch sets being created prior to the schema migration that added that field, the fact that these are represented in the database as null is an implementation detail. In practice we do not distinguish between empty groups and null groups, so potentially returning both of them from the API is confusing. Note that we definitely don't distinguish between these in the secondary index. Require that groups always be a non-null, and check for an empty group list to determine whether groups are "missing". This also means it's natural to use a List<String> for groups, which are naturally an ordered list. The one place where this doesn't hold is when coming out of GroupCollector, which for internal reasons needs to use a Set for deduplication. Have the few callers of that class copy the result to a list. Change-Id: I0b276e16b3ac02fd882ff1cb23d5dfd1fc7bcd20
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.