Google Git
Sign in
gerrit / gerrit / a692c291c4c700796b9d5c3ab0d3a3c1844a66d3
commita692c291c4c700796b9d5c3ab0d3a3c1844a66d3[log] [tgz]
authorFrank Borden <frankborden@google.com>Mon Jan 09 11:43:46 2023 +0100
committerFrank Borden <frankborden@google.com>Mon Jan 09 13:43:04 2023 +0100
treecdeda304f4a1e84226091bc95a6c8ad21be83218
parent32773ad89fa5d3f5cee6e5a006400a94eb6f6317 [diff]
Fix nav overlapping settings on specific screen sizes

https://imgur.com/a/39hLlbx

CSS grid could possibly avoid the complexity here but I am not
refactoring in this change.

Debugging and fix suggested by brohlfs@. His explanation is very nice
so I have reformatted and re-linked it below:

```
The screen width threshold for the div.main to become smaller is 67em =
67·16px = 1072px (note that em in media queries translates to 16px, the
browser font default):
https://cs.opensource.google/gerrit/gerrit/gerrit/+/master:polygerrit-ui/app/styles/gr-menu-page-styles.ts;l=35;drc=94fcbbc0a6ba92cd736fcc5307c045d6d3339eb3

Until that happens div.main has a width of 50em = 50·14px = 700px and
an auto margin (note that em here translates to 14px, the font size of
the parent element).
https://cs.opensource.google/gerrit/gerrit/gerrit/+/master:polygerrit-ui/app/styles/gr-menu-page-styles.ts;l=12;drc=94fcbbc0a6ba92cd736fcc5307c045d6d3339eb3

So on the left there is only a margin of (1072px - 700px - 16px) / 2 =
178px.

The absolutely positioned <nav> has a fixed width of 14em = 14·14px =
196px until it disappears at screen width 53em = 53·16px = 848px:
https://cs.opensource.google/gerrit/gerrit/gerrit/+/master:polygerrit-ui/app/elements/shared/gr-page-nav/gr-page-nav.ts;l=52;drc=42c1a45f81a8c45966b47622fd2dad2f37fc1439
https://cs.opensource.google/gerrit/gerrit/gerrit/+/master:polygerrit-ui/app/elements/shared/gr-page-nav/gr-page-nav.ts;l=57;drc=42c1a45f81a8c45966b47622fd2dad2f37fc1439

Since 196px is larger than 178px we have an overlap.

Maybe we should just change 67em here to 70em:
https://cs.opensource.google/gerrit/gerrit/gerrit/+/master:polygerrit-ui/app/styles/gr-menu-page-styles.ts;l=12;drc=94fcbbc0a6ba92cd736fcc5307c045d6d3339eb3
```

Release-Notes: skip
Google-Bug-Id: b/264603277
Change-Id: Ifc63d7f68b87106c1ba6f55e47a20b2e9692c9b8
1 file changed
tree: cdeda304f4a1e84226091bc95a6c8ad21be83218
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.