| commit | a58ddd2f8a4bd4c01648f8a80bb4692b073b0495 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Feb 02 08:53:25 2017 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Feb 02 13:08:42 2017 +0100 |
| tree | 6e6910a83687a5415b29c90eebf0e22caf99ae88 | |
| parent | 5ac0209bcef15b4fad2a7ffb504bdc141a8ededc [diff] |
Make error message for rejecting Egit placeholder Change-Id consistent
In the commit dialog Egit uses a placeholder for the Change-Id
("I0000000000000000000000000000000000000000") which it replaces later
with the real Change-Id. Some users thought that this placeholder also
works on the commandline, but of course there the replacement wasn't
done. As result of this there were lots of changes with this
placeholder Change-Id (as from the format it's a valid Change-Id) and
users got confused about updating each other changes. To prevent this
Gerrit rejects this placeholder Change-Id as invalid. However the
message for this was inconsistent with the message that is used for
other invalid Change-Ids.
Also all validations should be done in CommitValidators, but the check
for the Egit placeholder Change-Id was still done in ReceiveCommits.
Move the check to the right place.
Change-Id: I11c3c1a2d0023c4852d2fa6ec3a54a1245030377
Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.