| commit | a517acd8c2afcd696159de1f6b0fcc24b48c1057 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Tue Dec 21 14:17:43 2021 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Tue Dec 21 14:17:43 2021 +0100 |
| tree | 6eb3c09103b36bc77abbcd93508a4bd3b376eb2c | |
| parent | 133e1c70c3f30c7be3ddfbafcf0eeb8d048022c4 [diff] |
Ignore current violations of ThreadPriorityCheck and enable error level for it
There are 2 legacy usages of Thread#setPriority:
* WorkQueue:
- class to create thread pools for all kind of background tasks
- the thread priority is used to mark some thread pools as more
important than others to take priority if there are not enough free
threads
- the size of the thread pools is controlled by gerrit.config and
admins are advised to configure the thread pool sizes carefully by
taking the number of available processors into account
* AbstractLuceneIndex:
- class to do indexing when Lucene is used as index backend
- the thread priority is used to give the Lucene reopen thread a
higher priority than normal worker threads (the Lucene reopen thread
periodically updates some cached references in Lucene)
The recommendation for addressing ThreadPriorityCheck is to ensure that
the average number of runnable threads is not significantly greater than
the number of processors. It's the responsibility of admins to configure
the thread pool sizes accordingly. Using thread priorities in addition
shouldn't do any harm, hence we keep the current calls as they are.
However we enable the ThreadPriorityCheck ErrorProne bug pattern to get
aware of future usages and avoid them if possible.
Bug: Issue 15085
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I544da327c56fd884853d885bf725d21fd0f78e44
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.