Google Git
Sign in
gerrit / gerrit / be808375ba7b19736bc7951160643f7dd2152ac2
commitbe808375ba7b19736bc7951160643f7dd2152ac2[log] [tgz]
authorGal Paikin <paiking@google.com>Fri Jul 31 02:01:14 2020 +0300
committerGal Paikin <paiking@google.com>Fri Jul 31 09:52:11 2020 +0000
treeec71e5fbd9ceb8df8de0488c582f6abb66ab79b4
parent0dee8a09933cbd26edd1b5c04dac031d0fca85aa [diff]
Ensure reviewers are not added to attention set on submit

Originally fixed in If708dc98, but this only works for some submit
strategies. For other submit strategies, such as rebase always,
firstly the "rebase" is created which for some legacy reason, also
adds the person who performed the "submit as a reviewer. Then,
that person is added to the attention set. On the other hand,
with "merge if necessary" strategy, there is only one ChangeUpdate,
so the solution in the change above works.

The fix is simple: We can figure out that we're submitting a change
based on the legacy label, and then never add anyone to the attention
set, since all users should anyway be removed when submitting.

Change-Id: I0ce58a66eb3f9987050ea25125e91aa85e621883
3 files changed
tree: ec71e5fbd9ceb8df8de0488c582f6abb66ab79b4
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.