Improve autocompletion when adding topic
Before by pressing 'Enter' autocompletion closed a dialog and saved
autocomplete suggestion as topic even when user had different value
in input box.
Now 'enter' will just put autocompletion suggestion into input box and
user can decided if to save or not.
Google-Bug-Id: b/211036129
Change-Id: Ib20622f111dc7e0ff7a4b2e6134191fd8defa949
diff --git a/polygerrit-ui/app/elements/shared/gr-editable-label/gr-editable-label.ts b/polygerrit-ui/app/elements/shared/gr-editable-label/gr-editable-label.ts
index 7e6c17c..8564751 100644
--- a/polygerrit-ui/app/elements/shared/gr-editable-label/gr-editable-label.ts
+++ b/polygerrit-ui/app/elements/shared/gr-editable-label/gr-editable-label.ts
@@ -213,6 +213,10 @@
}
_handleEnter(event: KeyboardEvent) {
+ const grAutocomplete = this.getGrAutocomplete();
+ if (event.composedPath().some(el => el === grAutocomplete)) {
+ return;
+ }
const inputContainer = queryAndAssert(this, '.inputContainer');
const isEventFromInput = event
.composedPath()
@@ -233,7 +237,7 @@
}
_handleCommit() {
- this._save();
+ this.getInput()?.focus();
}
_computeLabelClass(readOnly?: boolean, value?: string, placeholder?: string) {
