| commit | a30b94509940d6a18b3851c10825ca97d4d2a6c0 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Fri Oct 10 09:48:29 2014 -0700 |
| committer | Dave Borowitz <dborowitz@google.com> | Tue Oct 14 16:50:46 2014 -0700 |
| tree | da5f70856633bb244d45409b7f99695fefc74d07 | |
| parent | 77ac934e8b1fe692bfcc5dbb41bc0b62027cf387 [diff] |
Refactor SubmitRuleEvaluator to reduce confusing arguments The multitude of string and optional boolean constructor arguments was a smell. Use a builder pattern for the optional ones, and add multiple methods for the 2 valid combinations of 4 string arguments, rather than requiring callers to know these magic values. Most other constructor arguments could be inferred directly from the ChangeData, so eliminate those as well. Change-Id: I2554e8574722dc022956d3ca8db4ad0dc36f8c0d