Google Git
Sign in
gerrit / gerrit / a04678d2a8d701a2c9bbbd5ddde7741ffe36d758
commita04678d2a8d701a2c9bbbd5ddde7741ffe36d758[log] [tgz]
authorDavid Pursehouse <dpursehouse@collab.net>Mon Oct 02 14:18:55 2017 +0100
committerDavid Pursehouse <dpursehouse@collab.net>Tue Oct 03 14:07:25 2017 +0100
tree407f1b3adb05c56b55e15ee1aa11456c4ae5cb4f
parent25df13c8978490dd6b2a26b949900fe45718f3e0 [diff]
DashboardsCollection#replace: Handle null input

If the input is null, dereferencing it to replace the project name
results in a NullPointerException.

This can happen for example when getting a dashboard that does not
have any description set. Such a dashboard is arguably invalid, but
since dashboards can currently only be created by manually writing
to the refs/meta/dashboards branch and there is no way to prevent
such invalid dashboards from being created, just add null handling
and return a dashboard info that has a null description.

When we later add support for creation of dashboards by REST, we
should include validation of the input.

Change-Id: I5d265e80faedf30edeb2654626c5d56e559f75cc
2 files changed
tree: 407f1b3adb05c56b55e15ee1aa11456c4ae5cb4f
  1. .settings/
  2. contrib/
  3. Documentation/
  4. gerrit-acceptance-framework/
  5. gerrit-acceptance-tests/
  6. gerrit-cache-h2/
  7. gerrit-common/
  8. gerrit-elasticsearch/
  9. gerrit-extension-api/
  10. gerrit-gpg/
  11. gerrit-gwtdebug/
  12. gerrit-gwtexpui/
  13. gerrit-gwtui/
  14. gerrit-gwtui-common/
  15. gerrit-httpd/
  16. gerrit-index/
  17. gerrit-launcher/
  18. gerrit-lucene/
  19. gerrit-main/
  20. gerrit-oauth/
  21. gerrit-openid/
  22. gerrit-patch-commonsnet/
  23. gerrit-patch-jgit/
  24. gerrit-pgm/
  25. gerrit-plugin-api/
  26. gerrit-plugin-gwtui/
  27. gerrit-prettify/
  28. gerrit-reviewdb/
  29. gerrit-server/
  30. gerrit-sshd/
  31. gerrit-test-util/
  32. gerrit-util-cli/
  33. gerrit-util-http/
  34. gerrit-util-ssl/
  35. gerrit-war/
  36. lib/
  37. plugins/
  38. polygerrit-ui/
  39. ReleaseNotes/
  40. tools/
  41. website/
  42. .bazelproject
  43. .editorconfig
  44. .git-blame-ignore-revs
  45. .gitignore
  46. .gitmodules
  47. .mailmap
  48. .pydevproject
  49. BUILD
  50. COPYING
  51. INSTALL
  52. README.md
  53. SUBMITTING_PATCHES
  54. version.bzl
  55. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.