Avoid queuing email tasks if sendemail.enable is false

The SmtpEmailSender respects the "sendemail.enable" configuration, but
previously, email notification tasks were still being constructed and
submitted to the email executor even when sending was disabled. This
resulted in unnecessary thread pool overhead and task queuing.

Introduce a @SendEmailEnabled binding annotation and a corresponding
provider to centrally manage the email enablement status. This status
is now injected into the following classes:
 - MergedByPushOp
 - ChangeInserter
 - EmailNewPatchSet
 - EmailReviewComments
 - EmailMerge
 - AttentionSetEmail
 - ModifyReviewersEmail

These classes now check the enablement status before submitting tasks
to the executor. SmtpEmailSender is also updated to use the injected
value instead of reading the configuration manually.

Bug: Issue 479683691
Release-Notes: Email tasks are no longer submitted when sendemail.enable is false
Change-Id: I59f9ef4a62673bbf7bf4dd73a7a0e2cb53074360
13 files changed
tree: 6247e738a8cee8cd6323e683833c764a89d92edd
  1. .github/
  2. .settings/
  3. .ts-out/
  4. antlr3/
  5. contrib/
  6. Documentation/
  7. e2e-tests/
  8. java/
  9. javatests/
  10. lib/
  11. modules/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. proto/
  17. resources/
  18. tools/
  19. webapp/
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. GEMINI.md
  35. INSTALL
  36. Jenkinsfile
  37. MODULE.bazel
  38. MODULE.bazel.lock
  39. package.json
  40. README.md
  41. SUBMITTING_PATCHES
  42. version.bzl
  43. web-dev-server.config.mjs
  44. WORKSPACE
  45. WORKSPACE.bzlmod
  46. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.