Show negated passing atoms as blocking submit requirements

A submit requirement that is unsatisfied because of a veto vote
(-label:Code-Review=MIN) is shown with a red "cancel" icon, while one
that is merely missing votes is shown with the neutral "block" icon.

Other requirements can be blocked in the same way, by something that
is present but must be absent. For example, a requirement like
"-subject:WIP" or "-prefixsubject:Edit" cannot be satisfied by adding
votes; the author must change the commit. These were shown with the
neutral icon, as if waiting for reviewers.

Treat an unsatisfied requirement as blocking when one of its passing
atoms is negated in the submittability expression, either with a unary
minus or with NOT. The veto vote case is a special case of this rule,
and the existing check for it is kept.

Note that this also applies to the default No-Unresolved-Comments
requirement (-has:unresolved), which is now shown as blocking while
there are unresolved comments. These also require action from the
author or the commenter rather than from additional voters.

Release-Notes: Unsatisfied submit requirements with a negated passing atom are shown as blocking
Change-Id: Ie5b938b3d376d736a010e58baf5c25ab09d56c85
2 files changed
tree: bdcceb3a31a4b6386bec94beaeca53da5e633673
  1. .agents/
  2. .aspect/
  3. .gemini/
  4. .github/
  5. .settings/
  6. .ts-out/
  7. antlr3/
  8. configs/
  9. contrib/
  10. Documentation/
  11. e2e-tests/
  12. java/
  13. javatests/
  14. lib/
  15. modules/
  16. plugins/
  17. polygerrit-ui/
  18. prolog/
  19. prologtests/
  20. proto/
  21. resources/
  22. tools/
  23. webapp/
  24. .bazelignore
  25. .bazelproject
  26. .bazelrc
  27. .bazelversion
  28. .editorconfig
  29. .git-blame-ignore-revs
  30. .gitignore
  31. .gitmodules
  32. .gitreview
  33. .mailmap
  34. .nvmrc
  35. .pydevproject
  36. .zuul.yaml
  37. AGENTS.md
  38. BUILD
  39. COPYING
  40. external_deps.lock.json
  41. INSTALL
  42. Jenkinsfile
  43. MODULE.bazel
  44. MODULE.bazel.lock
  45. package.json
  46. pnpm-lock.yaml
  47. pnpm-workspace.yaml
  48. README.md
  49. SUBMITTING_PATCHES
  50. web-dev-server.config.mjs
  51. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on GitHub.

Reporting bugs

Please report bugs on the issue tracker.

Due to spam abuse, membership in the repo-discuss Google Group is required in order to create issues. See the announcement for more info.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Due to spam abuse, membership in the repo-discuss Google Group is required in order to create Gerrit changes on the gerrit-review Gerrit server.

Note that we do not accept Pull Requests via the GitHub mirror.

Getting in contact

Find a full list of contact options on the website.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.