Google Git
Sign in
gerrit / gerrit / 9f86d9a8cdfb35bd604e03e9c68be67944aaf928
commit9f86d9a8cdfb35bd604e03e9c68be67944aaf928[log] [tgz]
authorChangcheng Xiao <xchangcheng@google.com>Fri Feb 17 11:45:19 2017 +0100
committerPatrick Hiesel <hiesel@google.com>Fri Feb 17 16:18:05 2017 +0100
tree23ae77570a0782697afce85e5c87a792348b3de7
parent8220a7a11ae05038f9b143ac48d07e6d143b6a73 [diff]
Fix GWT UI AddFileBox to provide path suggestions continuously

- How to reproduce the bug?
  In ChangeScreen, click 'Edit', then 'Add...'. Type in some text, you
  will get some path suggestions. Delete all the text you've typed in.
  There will be no suggestion any more until the page is reloaded.

- Why does this happen?
  The UI will continue create new query when the text box is focused
  and the 'query' is null in RemoteSuggestOracle. When the text box is
  cleared, it will result in a NullPointerException in
  RESTApi.addParameter(String, String) when it calls
  URL.encodeQueryString as the request.getQuery() is null. Once this
  exception happens, onSuggestionReady will not be called and 'query'
  field in RemoteSuggestOracle will not be reset to null. That's why
  the UI will not try new Request until the page is reloaded.

  This problem may be related to GWT 2.8 upgrade. It started behaving
  differently after the upgrade.

- Solution
  Don't add the query to the request if it is null. This solution will
  not affect ReviewerSuggestOracle as commit [1], which was revert by
  commit [2].

[1] https://gerrit-review.googlesource.com/#/c/97611/
[2] https://gerrit-review.googlesource.com/#/c/97731/

Bug: Issue 5365
Change-Id: Ie64bdf6384c022ec2be943ed9d67b1a1f3cee170
1 file changed
tree: 23ae77570a0782697afce85e5c87a792348b3de7
  1. .settings/
  2. contrib/
  3. Documentation/
  4. gerrit-acceptance-framework/
  5. gerrit-acceptance-tests/
  6. gerrit-antlr/
  7. gerrit-cache-h2/
  8. gerrit-common/
  9. gerrit-elasticsearch/
  10. gerrit-extension-api/
  11. gerrit-gpg/
  12. gerrit-gwtdebug/
  13. gerrit-gwtexpui/
  14. gerrit-gwtui/
  15. gerrit-gwtui-common/
  16. gerrit-httpd/
  17. gerrit-launcher/
  18. gerrit-lucene/
  19. gerrit-main/
  20. gerrit-oauth/
  21. gerrit-openid/
  22. gerrit-patch-commonsnet/
  23. gerrit-patch-jgit/
  24. gerrit-pgm/
  25. gerrit-plugin-api/
  26. gerrit-plugin-gwtui/
  27. gerrit-prettify/
  28. gerrit-reviewdb/
  29. gerrit-server/
  30. gerrit-sshd/
  31. gerrit-test-util/
  32. gerrit-util-cli/
  33. gerrit-util-http/
  34. gerrit-util-ssl/
  35. gerrit-war/
  36. lib/
  37. plugins/
  38. polygerrit-ui/
  39. ReleaseNotes/
  40. tools/
  41. website/
  42. .bazelproject
  43. .editorconfig
  44. .git-blame-ignore-revs
  45. .gitignore
  46. .gitmodules
  47. .mailmap
  48. .pydevproject
  49. BUILD
  50. COPYING
  51. INSTALL
  52. README.md
  53. SUBMITTING_PATCHES
  54. version.bzl
  55. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.