| commit | 9f65d91c035bc9ef591f8833b1b696d272372de9 | [log] [tgz] |
|---|---|---|
| author | Dhruv Srivastava <dhruvsri@google.com> | Mon Feb 22 10:36:19 2021 +0100 |
| committer | Dhruv Srivastava <dhruvsri@google.com> | Mon Feb 22 10:36:19 2021 +0100 |
| tree | c6f0dd9dc0d34c1374002ddd1ee3c57e27630a7c | |
| parent | 0dbce83d3531098c73d549c8c29ec66a765cd918 [diff] |
Add readonly to restApiService property From TSLint prefer-readonly-rule "Class fields should be marked as readonly if possible, to communicate that their value is never changed and prevent later accidental modification" Change-Id: Ib6444a230716d2106349f8413a398ae0c1a0a5fe
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts index 441d514..42741fa 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts
@@ -111,7 +111,7 @@ @property({type: String}) _repo: string | null = null; - private restApiService = appContext.restApiService; + private readonly restApiService = appContext.restApiService; /** @override */ created() {
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts index f36df84..f26cd46 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts +++ b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts
@@ -146,7 +146,7 @@ flagsService = appContext.flagsService; - private restApiService = appContext.restApiService; + private readonly restApiService = appContext.restApiService; keyboardShortcuts() { return {
diff --git a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts index 841ee6e..9240905 100644 --- a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts +++ b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts
@@ -121,7 +121,7 @@ private reporting = appContext.reportingService; - private restApiService = appContext.restApiService; + private readonly restApiService = appContext.restApiService; private lastVisibleTimestampMs = 0;
diff --git a/polygerrit-ui/app/elements/change-list/gr-user-header/gr-user-header.ts b/polygerrit-ui/app/elements/change-list/gr-user-header/gr-user-header.ts index 10f65a5..cfee0cd 100644 --- a/polygerrit-ui/app/elements/change-list/gr-user-header/gr-user-header.ts +++ b/polygerrit-ui/app/elements/change-list/gr-user-header/gr-user-header.ts
@@ -54,7 +54,7 @@ @property({type: String}) _status = ''; - private restApiService = appContext.restApiService; + private readonly restApiService = appContext.restApiService; _accountChanged(userId?: AccountId) { if (!userId) {