Google Git
Sign in
gerrit / gerrit / f97f253fa967739eae1b14a3d78498eeadc2f6e4
commitf97f253fa967739eae1b14a3d78498eeadc2f6e4[log] [tgz]
authorWyatt Allen <wyatta@google.com>Thu Nov 02 10:36:27 2017 -0700
committerWyatt Allen <wyatta@google.com>Thu Nov 02 17:15:18 2017 -0700
tree1c47ca3d4da5acf909dc0e227ca44a11adb9cf7e
parent344dbd603afc586922e394c623424d81cab0079f [diff]
Reload actions when new change is loaded, not on new changeNum

In Id4528de9e4, the change actions get reloaded when there is a new
change by reacting to changes in the changeNum or patchNum. However,
the change actions are not based on the selected patch set, instead they
are based on the "latest patch set", and the latest patch set can only
be known when the revisions are loaded (from the change object). As
such, when only the new changeNum was known but the new change object
was not yet loaded, the patchNum based on the change object would be
stale. If the stale patchNum is not valid on the new change this
resulted in a 404 in the actions request.

With this change, the change actions are reloaded when the change object
changes, since this implies that the patchNum will no longer be stale.

Bug: Issue 7622
Change-Id: Ia6fa8ec41b63b02d9f2e6b69cf4225e07b2fae9f
2 files changed
tree: 1c47ca3d4da5acf909dc0e227ca44a11adb9cf7e
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. gerrit-gwtdebug/
  6. gerrit-gwtui/
  7. gerrit-gwtui-common/
  8. gerrit-plugin-gwtui/
  9. java/
  10. javatests/
  11. lib/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. ReleaseNotes/
  17. resources/
  18. tools/
  19. webapp/
  20. website/
  21. .bazelproject
  22. .editorconfig
  23. .git-blame-ignore-revs
  24. .gitignore
  25. .gitmodules
  26. .mailmap
  27. .pydevproject
  28. BUILD
  29. COPYING
  30. INSTALL
  31. README.md
  32. SUBMITTING_PATCHES
  33. version.bzl
  34. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.