commit fc0ebdad73d87857a44da8c081a27bbb25a0cfd1
author David Pursehouse <dpursehouse@collab.net> Thu Feb 20 11:03:02 2020 +0900
committer David Pursehouse <dpursehouse@collab.net> Thu Mar 19 16:03:45 2020 +0900
tree 1a0a640e83934f7a4df1ed43713af87b351c79cc
parent cde32142949253b6d681bdc5d380500af620927e

ChangeQueryBuilder: Throw error on ambiguous visibleto by display name

If the given account identifier resolved to more than one user, the
visibleto would only use the first user from the result. This was OK
for queries by username or account ID because they always resolve to
either no user or exactly one user. However when querying by display
name it is possible that multiple users will be returned, and in this
case it was incorrect to only use the first one.

Fix it to instead throw an error when multiple accounts are resolved,
and extend the tests to cover this use case.

This has been broken since change I87e58dda4 which was introduced in
2012 and was discovered by Sonar Lint which reported the following
message on the broken code:

  Loops with at most one iteration should be refactored (squid:S1751)

  A loop with at most one iteration is equivalent to the use of an if
  statement to conditionally execute one piece of code. No developer
  expects to find such a use of a loop statement. If the initial
  intention of the author was really to conditionally execute one piece
  of code, an if statement should be used instead.

  At worst that was not the initial intention of the author and so the
  body of the loop should be fixed to use the nested return, break or
  throw statements in a more appropriate way.

Change-Id: Ibb16a70e6cc61c22516f5d9ac3e1b6b461c94dc2